Skip to content

Sync with GGML: add GGML bf16 support#2640

Closed
EricLBuehler wants to merge 2 commits into
huggingface:mainfrom
EricLBuehler:sync_add_gguf_bf16
Closed

Sync with GGML: add GGML bf16 support#2640
EricLBuehler wants to merge 2 commits into
huggingface:mainfrom
EricLBuehler:sync_add_gguf_bf16

Conversation

@EricLBuehler

@EricLBuehler EricLBuehler commented Nov 26, 2024

Copy link
Copy Markdown
Member

This is part 1 of 3 chunks of #2615 for easier review.

It synchronizes the GGML kernels to support bf16.

I will open the others sequentially as this one is merged.

* Add GGUF bf16 type support

* Add non avx impl for vec_dot_bf16

* Fix from_u32

* Fix loading

* Fix dequant of bf16
* Update kernels for metal bf16

* Fix typo

* Check if have bfloat

@ivarflakstad ivarflakstad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@EricLBuehler

Copy link
Copy Markdown
Member Author

Thanks for reviewing! @LaurentMazare can you please take a look perhaps?

@EricLBuehler EricLBuehler deleted the sync_add_gguf_bf16 branch December 4, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants